[
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258763#comment-13258763
]
Zhihong Yu commented on HBASE-5652:
-----------------------------------
{code}
+ if(status != null) status.cleanup();
{code}
Please insert space between if and (.
{code}
+ try {
+ this.logRollRunning = false;
+ } finally {
+ this.cacheFlushLock.unlock();
+ }
{code}
The assignment wouldn't throw exception. Is the above try block needed ?
> [findbugs] Fix lock release on all paths
> -----------------------------------------
>
> Key: HBASE-5652
> URL: https://issues.apache.org/jira/browse/HBASE-5652
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Attachments: HBASE-5652-v0.patch
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
> Category UL
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
