Gregory Chanan commented on HBASE-5652:

will update spacing

will update test-patch.properties

On the assignment not being able to throw an exception, I agree.  However it 
seems better to put it into a try/finally because:
1) it keeps the pattern the same with other usages
2) it works even if the line changes.  Imagine if we made it an exclude and 
then the line changed to something that could throw an exception.  We wouldn't 
see the warning because the exclude would hide it.
3) as noted by Uma, exceptions are fragile, e.g. if you rename the function you 
also have to change the exclude.
> [findbugs] Fix lock release on all paths 
> -----------------------------------------
>                 Key: HBASE-5652
>                 URL: https://issues.apache.org/jira/browse/HBASE-5652
>             Project: HBase
>          Issue Type: Sub-task
>          Components: scripts
>            Reporter: Jonathan Hsieh
>            Assignee: Gregory Chanan
>         Attachments: HBASE-5652-v0.patch
> See 
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
> Category UL

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to