virajjasani commented on a change in pull request #1511: HBASE-24139 : Balancer
should avoid leaving idle region servers
URL: https://github.com/apache/hbase/pull/1511#discussion_r409630141
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##########
@@ -1192,6 +1192,8 @@ protected boolean needsBalance(TableName tableName,
Cluster c) {
return false;
}
if(areSomeRegionReplicasColocated(c)) return true;
+ if(idleRegionExist(c)) return true;
Review comment:
please use { } for the statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
