Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-619884550
The function here is like region replica so I do not think we should implement it in the rpc framework, as the prepered way in HBase, is to implement a special RpcRetryingCaller. Anyway MasterRegistry is a bit strange, as it is the root of the client implementation, so we can not make use of the existing rpc retrying caller, but anyway, implement the hedge logic in MasterRegistry is still easier than in the rpc framework. And I dropped the fan out parameter. This is because that, usually we will only have 2 masters, and even if we have more, I do not think it makes much difference. So I only support two options, send the request one by one, or send them altogether at the same time. And since now the logic is in MasterRegistry, both rpc client implementation can work with MasterRegistry. PTAL. @saintstack @bharathv Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
