Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620283327
And if you guys really want to implement the hedge read support, please open a new issue for it, and implement the feature in both rpc client implementations, and make it suitable for other operations as well, not only for MasterRegistry. For example, support the read replica feature. Now the implementation was pulled in as a side effect of MasterRegistry, and lacked of lots of features. For example, only support NettyRpcClient, do not have built in retries support, etc. To be clear, it is not a good idea to expose a feature which may have a long term impacting when implementing another feature. Developers may accidentally use it and then it becomes a cancer of the code since it is not in a good shape at the beginning. I spent a lot of time to purge the old stale code in sync client, both in rpc implementation and the old retrying caller, especially, the big big AsyncProcess class. I do not want to do it in the future again. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
