bsglz commented on a change in pull request #1500:
URL: https://github.com/apache/hbase/pull/1500#discussion_r416283728
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -877,6 +877,19 @@ public HRegion(final HRegionFileSystem fs, final WAL wal,
final Configuration co
this.maxCellSize = conf.getLong(HBASE_MAX_CELL_SIZE_KEY,
DEFAULT_MAX_CELL_SIZE);
this.miniBatchSize = conf.getInt(HBASE_REGIONSERVER_MINIBATCH_SIZE,
DEFAULT_HBASE_REGIONSERVER_MINIBATCH_SIZE);
+
+ // recover the metrics of read and write requests count if they were
retained
+ if (rsServices != null) {
Review comment:
In this case, the metrics would be zero, i think it is correct.
BTW, there are three type of statistical calibers on region r/w count:
1. cumulative by all regionserver
2. cumulative by independent regionserver
3. cumulative by independent regionserver in continuous time range
IMO, the third one is more clear to users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
