bsglz commented on a change in pull request #1500:
URL: https://github.com/apache/hbase/pull/1500#discussion_r416293843
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
##########
@@ -67,6 +70,7 @@ public RegionServerAccounting(Configuration conf) {
this.globalOnHeapMemstoreLimit =
MemorySizeUtil.getOnheapGlobalMemStoreSize(conf);
this.globalOnHeapMemstoreLimitLowMark =
(long) (this.globalOnHeapMemstoreLimit *
this.globalMemStoreLimitLowMarkPercent);
+ this.retainedRegionRWRequestsCnt = new ConcurrentHashMap<>();
Review comment:
> This data structure can grow w/o bound?
The entry of it will be removed in time, so will not grow too big.
> This data structure needs a comment on how it is used and life cycle of
items. They items should age out I'd think.
Added some comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
