Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-622941710
Ping @ndimiduk and @saintstack , what do you guys think? I've replied on #1601 , at least the current implementation does not make sense to me, there is no reason that why we can only support NettyRpcClient. FWIW, I do not see any advantages on moving the logic from AsyncRpcRetryingCaller down to the rpc framework, except that the MasterRegistry can make use of it, but implementing the logic in MasterRegistry only requires a very small amount of code piece, and can do better error handling than implementing in the rpc framework, so I do not think it worths. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
