bharathv commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-623164081
> Ping @ndimiduk and @saintstack , what do you guys think? I've replied on #1601 , at least the current implementation does not make sense to me, there is no reason that why we can only support NettyRpcClient. Your comments on #1601 make sense to me. Thanks for taking a look. It was a misunderstanding on my part that the BlockingRpcConnection implementation always defaulted to a blocking channel implementation, I took a closer look at the code after your comments and that cleared it up. This means it is much easier to support all RpcClients if we wrap the channels in HedgedRpcChannel. So, I think this can be fixed. I think the whole discussion now boils down to whether we want to have the abstraction of hedging in RPC layer or not. - Looks like your opinion is no. - My take, I definitely understand your argument and see where you are coming from but I think the abstraction doesn't hurt (as long as it is implemented correctly). So I have a slight preference to include it in the RPC layer and I don't mind if the majority vote is the other way. - Do other reviewers/followers have any strong opinion either way? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
