anoopsjohn commented on a change in pull request #1675:
URL: https://github.com/apache/hbase/pull/1675#discussion_r422327852
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java
##########
@@ -137,4 +138,14 @@ public int getNumObservers() {
return configurationObservers.size();
}
}
+
+ /**
+ * @return the observers
+ */
+ @VisibleForTesting
+ public Set<ConfigurationObserver> getConfigurationObservers() {
Review comment:
This is used by tests only. But still how this synchronized block helps
here? We are directly returning that object which is not thread safe. IMO we
should add a method like containObserver (or a better name?) and just return a
boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
