anoopsjohn commented on a change in pull request #1675:
URL: https://github.com/apache/hbase/pull/1675#discussion_r422624939



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java
##########
@@ -137,4 +138,14 @@ public int getNumObservers() {
       return configurationObservers.size();
     }
   }
+
+  /**
+   * @return the observers
+   */
+  @VisibleForTesting
+  public Set<ConfigurationObserver> getConfigurationObservers() {

Review comment:
       Here the boolean based API is enough.  That is what u did now.
   Nit change method name   containObserver  -> containsObserver




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to