[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260280#comment-13260280
]
stack commented on HBASE-5732:
------------------------------
@Devaraj If this patch only works against 1.0.x hadoop, what do we do when we
want to run hbase 0.96 on hadoop 2.0.x?
Here is some more feedback on posted patch:
Its big! Its mostly deletes and generated code though thankfully.
So, you are going to move to UGI over User?
Are you going to get rid of the security dir that is at top level in hbase? Is
there anything left in it after this patch?
What kind of hadoop will be required? One that supports security: i.e. apache
hadoop 1.0.x, 2.0.x? And then for the others? The will need to have an answer
for the security methods?
Just remove rather than do this commenting out:
{code}
- builder.setError(error != null);
+ //builder.setStatus(
{code}
This is going to make a copy of the response?
{code}
+ token = connection.saslServer.wrap(buf.array(),
+ buf.arrayOffset(), buf.remaining());
{code}
Do we have to? Can't we feed it out on the output stream, first the wrapping,
then the response?
Any tests?
Good stuff.
> Remove the SecureRPCEngine and merge the security-related logic in the core
> engine
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5732
> URL: https://issues.apache.org/jira/browse/HBASE-5732
> Project: HBase
> Issue Type: Improvement
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Attachments: rpcengine-merge.patch
>
>
> Remove the SecureRPCEngine and merge the security-related logic in the core
> engine. Follow up to HBASE-5727.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
