[ https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261853#comment-13261853 ]
Devaraj Das commented on HBASE-5732: ------------------------------------ In the last patch, I missed adding the AuthenticationTokenSecretManager instantiation in the default RPC engine (and a security unit test failed). I've taken that into consideration now.. Andrew, how about instantiating the AuthenticationTokenSecretManager (that has dependency on ZK) only if isSecurityEnabled() returns true.. The problem with this is that the unit tests also won't instantiate the manager.. for unit tests, maybe we can have a minimal RpcEngine implementation that returns a Server object that internally instantiates the AuthenticationTokenSecretManager unconditionally.. Would that work? > Remove the SecureRPCEngine and merge the security-related logic in the core > engine > ---------------------------------------------------------------------------------- > > Key: HBASE-5732 > URL: https://issues.apache.org/jira/browse/HBASE-5732 > Project: HBase > Issue Type: Improvement > Reporter: Devaraj Das > Assignee: Devaraj Das > Attachments: rpcengine-merge.3.patch, rpcengine-merge.patch > > > Remove the SecureRPCEngine and merge the security-related logic in the core > engine. Follow up to HBASE-5727. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira