wenbang commented on a change in pull request #1742:
URL: https://github.com/apache/hbase/pull/1742#discussion_r429076319
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -8265,14 +8265,17 @@ private WALEdit reckonDeltas(Operation op, Mutation
mutation, Durability effecti
break;
default: throw new UnsupportedOperationException(op.toString());
}
- int newCellSize = PrivateCellUtil.estimatedSerializedSizeOf(newCell);
- if (newCellSize > this.maxCellSize) {
- String msg = "Cell with size " + newCellSize + " exceeds limit of " +
this.maxCellSize
- + " bytes in region " + this;
- if (LOG.isDebugEnabled()) {
+ if (this.maxCellSize > 0) {
+ int newCellSize = PrivateCellUtil.estimatedSerializedSizeOf(newCell);
+ if (newCellSize > this.maxCellSize) {
+ String msg = "Cell with size " + newCellSize + " exceeds limit of "
+ this.maxCellSize
+ + " bytes in region " + this;
LOG.debug(msg);
+ throw new DoNotRetryIOException(msg);
}
- throw new DoNotRetryIOException(msg);
+ } else {
+ LOG.debug("Cell size check is disabled because of maxCellSize is set
to {}.",
Review comment:
> Well, that's why I suggested it to be DEBUG. Logging it only once may
not be sufficient in cases where log rolls too quickly.
We could check it in the regionserver configuration and table desc. It ’s OK
to remove this log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
