wchevreuil commented on a change in pull request #1742:
URL: https://github.com/apache/hbase/pull/1742#discussion_r429174718
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -8265,14 +8265,17 @@ private WALEdit reckonDeltas(Operation op, Mutation
mutation, Durability effecti
break;
default: throw new UnsupportedOperationException(op.toString());
}
- int newCellSize = PrivateCellUtil.estimatedSerializedSizeOf(newCell);
- if (newCellSize > this.maxCellSize) {
- String msg = "Cell with size " + newCellSize + " exceeds limit of " +
this.maxCellSize
- + " bytes in region " + this;
- if (LOG.isDebugEnabled()) {
+ if (this.maxCellSize > 0) {
+ int newCellSize = PrivateCellUtil.estimatedSerializedSizeOf(newCell);
+ if (newCellSize > this.maxCellSize) {
+ String msg = "Cell with size " + newCellSize + " exceeds limit of "
+ this.maxCellSize
+ + " bytes in region " + this;
LOG.debug(msg);
+ throw new DoNotRetryIOException(msg);
}
- throw new DoNotRetryIOException(msg);
+ } else {
+ LOG.debug("Cell size check is disabled because of maxCellSize is set
to {}.",
Review comment:
Many users and even experienced developers may not be aware of this
changed behaviour. When things don't seem to work as expected, and one doesn't
have an idea about why, decreasing the log level to gather as much info as
possible is a common practice. I know it would be verbose, but that's why we
should make it either a DEBUG or a TRACE level message. The message then would
give a clear clue for those who didn't even know about the config property or
table attribute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
