anoopsjohn commented on a change in pull request #1765:
URL: https://github.com/apache/hbase/pull/1765#discussion_r429561701
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/RegionReplicaFlushHandler.java
##########
@@ -130,11 +130,7 @@ void triggerFlushInPrimaryRegion(final HRegion region)
throws IOException {
ServerRegionReplicaUtil.getRegionInfoForDefaultReplica(region.getRegionInfo())
.getRegionNameAsString(),
region.getRegionInfo().getRegionNameAsString(),
counter.getAttemptTimes(), e);
- try {
Review comment:
You did not get what I was saying I believe.
This is triggerFlushInPrimaryRegion() method and u can see a while loop
within which the call happening. The while loop is to be terminated once this
RS is set to be stopped/abort. When such happens, there might be many non
daemon threads running within the server. Our logic in different places will
interrupt these threads. so if the thread is sleeping or waiting it will get
InterruptedException and allow the thread NOT to continue in running/waiting
state. The logic should be checking the server status and allow to come out of
loops etc.
But your change will make it such that even if the main thread interrupt
this thread, it will continue to sleep for the specified time. That is totally
against our intent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
