anoopsjohn commented on a change in pull request #1765:
URL: https://github.com/apache/hbase/pull/1765#discussion_r429596288
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/RegionReplicaFlushHandler.java
##########
@@ -130,11 +130,7 @@ void triggerFlushInPrimaryRegion(final HRegion region)
throws IOException {
ServerRegionReplicaUtil.getRegionInfoForDefaultReplica(region.getRegionInfo())
.getRegionNameAsString(),
region.getRegionInfo().getRegionNameAsString(),
counter.getAttemptTimes(), e);
- try {
Review comment:
I did not check all places.. Most of the places where the RetryCounter
is being used is in test I can see. But within RetryCounter we should not
change. Tomorrow some other code path might use it too. IMO we can just keep
the code as is. Let the calling part handle the InterruptedException the way
they want. we can not generalise it. So just close this Jira Viraj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
