songxincun commented on a change in pull request #1803:
URL: https://github.com/apache/hbase/pull/1803#discussion_r432792487
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1192,8 +1198,10 @@ public StoreFileWriter createWriterInTmp(long
maxKeyCount, Compression.Algorithm
if (shouldCacheDataOnWrite) {
writerCacheConf.enableCacheOnWrite();
if (!cacheOnWriteLogged) {
- LOG.info("For Store {} , cacheDataOnWrite is true, hence enabled
cacheOnWrite for " +
- "Index blocks and Bloom filter blocks", getColumnFamilyName());
+ LOG.info("For Store {} in region {}, " +
Review comment:
> No need of 'Store' or 'region'... its obvious that we're talking store
and region. Having these works in there bulk up logging and make it harder to
read/parse.
Got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
