songxincun commented on a change in pull request #1803:
URL: https://github.com/apache/hbase/pull/1803#discussion_r432792434
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -331,11 +332,11 @@ protected HStore(final HRegion region, final
ColumnFamilyDescriptor family,
confPrintThreshold = 10;
}
this.parallelPutCountPrintThreshold = confPrintThreshold;
- LOG.info("Store={}, memstore type={}, storagePolicy={},
verifyBulkLoads={}, "
- + "parallelPutCountPrintThreshold={}, encoding={}, compression={}",
+ LOG.info("Created HStore: Store={}, memstore type={}, storagePolicy={},
verifyBulkLoads={}, "
Review comment:
> Why have 'HStore:' in here? Instead of 'Created HStore: Store=', just
have 'Created '.
Got it
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -331,11 +332,11 @@ protected HStore(final HRegion region, final
ColumnFamilyDescriptor family,
confPrintThreshold = 10;
}
this.parallelPutCountPrintThreshold = confPrintThreshold;
- LOG.info("Store={}, memstore type={}, storagePolicy={},
verifyBulkLoads={}, "
- + "parallelPutCountPrintThreshold={}, encoding={}, compression={}",
+ LOG.info("Created HStore: Store={}, memstore type={}, storagePolicy={},
verifyBulkLoads={}, "
+ + "parallelPutCountPrintThreshold={}, encoding={}, compression={}
in region {}",
getColumnFamilyName(), memstore.getClass().getSimpleName(),
policyName, verifyBulkLoads,
parallelPutCountPrintThreshold, family.getDataBlockEncoding(),
- family.getCompressionType());
+ family.getCompressionType(), getRegionInfo().getRegionNameAsString());
Review comment:
> Encoded name, not full name.
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
