saintstack commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r432909987
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -284,18 +284,21 @@ public static LocalRegion create(LocalRegionParams
params) throws IOException {
Configuration conf = new Configuration(baseConf);
CommonFSUtils.setRootDir(conf, rootDir);
CommonFSUtils.setWALRootDir(conf, walRootDir);
- LocalRegionFlusherAndCompactor.setupConf(conf, params.flushSize(),
params.flushPerChanges(),
+ MasterRegionFlusherAndCompactor.setupConf(conf, params.flushSize(),
params.flushPerChanges(),
params.flushIntervalMs());
conf.setInt(AbstractFSWAL.MAX_LOGS, params.maxWals());
if (params.useHsync() != null) {
conf.setBoolean(HRegion.WAL_HSYNC_CONF_KEY, params.useHsync());
}
+ if (params.useMetaCellComparator() != null) {
Review comment:
We need to add this in here?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -284,18 +284,21 @@ public static LocalRegion create(LocalRegionParams
params) throws IOException {
Configuration conf = new Configuration(baseConf);
CommonFSUtils.setRootDir(conf, rootDir);
CommonFSUtils.setWALRootDir(conf, walRootDir);
- LocalRegionFlusherAndCompactor.setupConf(conf, params.flushSize(),
params.flushPerChanges(),
+ MasterRegionFlusherAndCompactor.setupConf(conf, params.flushSize(),
params.flushPerChanges(),
params.flushIntervalMs());
conf.setInt(AbstractFSWAL.MAX_LOGS, params.maxWals());
if (params.useHsync() != null) {
conf.setBoolean(HRegion.WAL_HSYNC_CONF_KEY, params.useHsync());
}
+ if (params.useMetaCellComparator() != null) {
Review comment:
This was missing?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java
##########
@@ -89,45 +82,8 @@
private static final TableDescriptor TABLE_DESC =
TableDescriptorBuilder.newBuilder(TABLE_NAME)
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(PROC_FAMILY)).build();
- private final LocalRegion region;
-
- private LocalStore(LocalRegion region) {
- this.region = region;
- }
-
- public void update(UpdateLocalRegion action) throws IOException {
- region.update(action);
- }
-
- public Result get(Get get) throws IOException {
- return region.get(get);
- }
-
- public RegionScanner getScanner(Scan scan) throws IOException {
- return region.getScanner(scan);
- }
-
- public void close(boolean abort) {
- region.close(abort);
- }
-
- @VisibleForTesting
- public FlushResult flush(boolean force) throws IOException {
- return region.flush(force);
- }
-
- @VisibleForTesting
- public void requestRollAll() {
- region.requestRollAll();
- }
-
- @VisibleForTesting
- public void waitUntilWalRollFinished() throws InterruptedException {
- region.waitUntilWalRollFinished();
- }
-
- public static LocalStore create(Server server) throws IOException {
- LocalRegionParams params = new LocalRegionParams().server(server)
Review comment:
How comes we can drop these methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
