Apache9 commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r433582964
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -79,14 +79,14 @@
* Notice that, you can use different root file system and WAL file system.
Then the above directory
* will be on two file systems, the root file system will have the data
directory while the WAL
* filesystem will have the WALs directory. The archived HFile will be moved
to the global HFile
- * archived directory with the {@link LocalRegionParams#archivedWalSuffix()}
suffix. The archived
+ * archived directory with the {@link MasterRegionParams#archivedWalSuffix()}
suffix. The archived
* WAL will be moved to the global WAL archived directory with the
- * {@link LocalRegionParams#archivedHFileSuffix()} suffix.
+ * {@link MasterRegionParams#archivedHFileSuffix()} suffix.
*/
@InterfaceAudience.Private
-public final class LocalRegion {
+public final class MasterRegion {
Review comment:
This is intentional. You can see the implementation of
MasterRegion.update, we have to call `flusherAndCompactor.onUpdate();` after
each update. So if we expose the HRegion directly, the callers have to do this
by their own, and I believe it will be easy to forget and then cause big
problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
