phrocker commented on a change in pull request #3:
URL: https://github.com/apache/hbase-native-client/pull/3#discussion_r434013866
##########
File path: .gitignore
##########
@@ -33,7 +33,7 @@ simple-client
# CMake temporary files
CMakeCache.txt
CMakeFiles
-*.cmake
+#*.cmake
Review comment:
i commented this out as a point of discussion as this could cause issues
for maintainers, though it could be assumed that a PR should be evaluated and
therefore we should not run into an actual issue by ignoring cmake files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
