apurtell commented on a change in pull request #1860:
URL: https://github.com/apache/hbase/pull/1860#discussion_r438943247
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java
##########
@@ -52,15 +53,16 @@ public RecoveredEditsOutputSink(WALSplitter walSplitter,
}
@Override
- public void append(EntryBuffers.RegionEntryBuffer buffer) throws IOException
{
+ public void append(EntryBuffers.RegionEntryBuffer buffer, MonitoredTask
status)
Review comment:
Same
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -129,10 +138,13 @@ long getTotalSkippedEdits() {
/**
* @param buffer A buffer of some number of edits for a given region.
+ * @param status MonitoredTask instance to capture WAL splitting
+ * @throws IOException For any IO errors
*/
- abstract void append(EntryBuffers.RegionEntryBuffer buffer) throws
IOException;
+ abstract void append(EntryBuffers.RegionEntryBuffer buffer, MonitoredTask
status)
+ throws IOException;
- abstract List<Path> close() throws IOException;
+ abstract List<Path> close(MonitoredTask status) throws IOException;
Review comment:
Same
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredEditsOutputSink.java
##########
@@ -57,7 +58,8 @@ public BoundedRecoveredEditsOutputSink(WALSplitter
walSplitter,
}
@Override
- public void append(EntryBuffers.RegionEntryBuffer buffer) throws IOException
{
+ public void append(EntryBuffers.RegionEntryBuffer buffer, MonitoredTask
status)
Review comment:
Does this context have access to the OutputSink's MonitoredTask field?
Can we do that instead, so we don't have to change these method signatures?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredEditsOutputSink.java
##########
@@ -83,25 +85,26 @@ public void append(EntryBuffers.RegionEntryBuffer buffer)
throws IOException {
}
@Override
- public List<Path> close() throws IOException {
+ public List<Path> close(MonitoredTask status) throws IOException {
Review comment:
Does this context have access to the OutputSink's MonitoredTask field?
Can we do that instead, so we don't have to change these method signatures?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java
##########
@@ -86,26 +88,27 @@ private RecoveredEditsWriter
getRecoveredEditsWriter(TableName tableName, byte[]
}
@Override
- public List<Path> close() throws IOException {
+ public List<Path> close(MonitoredTask status) throws IOException {
Review comment:
Same
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java
##########
@@ -86,26 +88,27 @@ private RecoveredEditsWriter
getRecoveredEditsWriter(TableName tableName, byte[]
}
@Override
- public List<Path> close() throws IOException {
+ public List<Path> close(MonitoredTask status) throws IOException {
boolean isSuccessful = true;
try {
- isSuccessful &= finishWriterThreads();
+ isSuccessful = finishWriterThreads();
} finally {
- isSuccessful &= closeWriters();
+ isSuccessful &= closeWriters(status);
}
return isSuccessful ? splits : null;
}
/**
* Close all of the output streams.
*
+ * @param status MonitoredTask instance to capture WAL splitting
* @return true when there is no error.
*/
- private boolean closeWriters() throws IOException {
+ private boolean closeWriters(MonitoredTask status) throws IOException {
Review comment:
Same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
