virajjasani commented on a change in pull request #1860:
URL: https://github.com/apache/hbase/pull/1860#discussion_r441051142
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java
##########
@@ -233,7 +251,10 @@ void writeRegionEntries(List<WAL.Entry> entries) throws
IOException {
incrementNanoTime(System.nanoTime() - startTime);
} catch (IOException e) {
e = e instanceof RemoteException ? ((RemoteException)
e).unwrapRemoteException() : e;
- LOG.error(HBaseMarkers.FATAL, "Got while writing log entry to log", e);
+ final String errorMsg =
+ "Failed to write log entry " + currentWalEntry.toString() + " to
log";
Review comment:
IOException is thrown by `writer.append(logEntry)` and when we reach
there, we are quite certain that `currentWalEntry` will be assigned some value
for sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
