anoopsjohn commented on a change in pull request #1869:
URL: https://github.com/apache/hbase/pull/1869#discussion_r439206892



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1285,7 +1285,9 @@ private boolean waitForNamespaceOnline() throws 
InterruptedException, IOExceptio
     }
     // Else there are namespace regions up in meta. Ensure they are assigned 
before we go on.
     for (RegionInfo ri : ris) {
-      isRegionOnline(ri);
+      if (!isRegionOnline(ri)) {

Review comment:
       BTW our RetryCounterFactory is with infinite retry. maxAttempts are 
Integer.MAX_VALUE.  Also we don't account for a case whether 
RetryCounterFactory finishes the retry attempts. 
   There is no harm in adding this fix.  But should we see whether the 
RetryCounterFactory  usage is correct also?
   Am I missing some thing?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to