bharathv commented on a change in pull request #1892:
URL: https://github.com/apache/hbase/pull/1892#discussion_r439947863
##########
File path:
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
##########
@@ -1767,6 +1769,12 @@ public void testSlowLogResponses() throws Exception {
clearedResponses.forEach(Assert::assertTrue);
TLogQueryFilter tLogQueryFilter = new TLogQueryFilter();
tLogQueryFilter.setLimit(15);
+ Assert.assertEquals(tLogQueryFilter.getFilterByOperator(),
TFilterByOperator.OR);
+ LogQueryFilter logQueryFilter =
ThriftUtilities.getSlowLogQueryFromThrift(tLogQueryFilter);
Review comment:
Umm, if we came this far, why not make an RPC and validate the result
set too? :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
