virajjasani commented on a change in pull request #1892:
URL: https://github.com/apache/hbase/pull/1892#discussion_r440011435
##########
File path:
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
##########
@@ -1767,6 +1769,12 @@ public void testSlowLogResponses() throws Exception {
clearedResponses.forEach(Assert::assertTrue);
TLogQueryFilter tLogQueryFilter = new TLogQueryFilter();
tLogQueryFilter.setLimit(15);
+ Assert.assertEquals(tLogQueryFilter.getFilterByOperator(),
TFilterByOperator.OR);
+ LogQueryFilter logQueryFilter =
ThriftUtilities.getSlowLogQueryFromThrift(tLogQueryFilter);
Review comment:
Ah I see, yes that is quite valid point :)
However, the issue with testing this way is: For our case, we don't have any
Add/Update API, we just have Get API, and the event that trigger Add event is
something not in client test's control (only at RpcServer level, we have
control to identify if an RPC call was slow/large by nature).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
