ndimiduk commented on a change in pull request #1862: URL: https://github.com/apache/hbase/pull/1862#discussion_r440516792
########## File path: dev-support/create-release/do-release-docker.sh ########## @@ -85,12 +86,14 @@ IMGTAG=latest JAVA= RELEASE_STEP= GIT_REPO= -while getopts "d:fhj:p:r:s:t:" opt; do +MAVEN_VOLUME= +while getopts "d:fhj:m:p:r:s:t:" opt; do case $opt in d) WORKDIR="$OPTARG" ;; f) DRY_RUN=0 ;; t) IMGTAG="$OPTARG" ;; j) JAVA="$OPTARG" ;; + m) MAVEN_VOLUME="$OPTARG" ;; Review comment: why not lake this a flag, and just always use a path under the build directory? You want to reuse it across invocations of do-release? That strikes me as undesirable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org