[
https://issues.apache.org/jira/browse/HBASE-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263129#comment-13263129
]
Elliott Clark commented on HBASE-5886:
--------------------------------------
* This patch fails unit tests. org.apache.hadoop.hbase.io.TestHeapSize
* recordPossibleDataLossNoWal seems like the wrong name. There's no possible
data loss until a region server crashes without flushing. Maybe something like
recordPutWithoutWal.
* I don't think the warn in recordPossibleDataLossNoWal is the right level.
Nothing has gone wrong; someone has just decided to opt for a speedy put vs a
safe one. I'm not even sure that a log is needed here.
* How far off of the actual size of the data is the heapSize of the kv ?
* Putting data about puts without WAL into
org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics seems like it
would be good.
> Add new metric for possible data loss due to puts without WAL
> --------------------------------------------------------------
>
> Key: HBASE-5886
> URL: https://issues.apache.org/jira/browse/HBASE-5886
> Project: HBase
> Issue Type: New Feature
> Components: metrics, regionserver
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Minor
> Labels: metrics
> Attachments: HBASE-5886-v0.patch
>
>
> Add a metrics to keep track of puts without WAL and possible data loss size.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
