[ 
https://issues.apache.org/jira/browse/HBASE-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matteo Bertozzi updated HBASE-5886:
-----------------------------------

    Attachment: HBASE-5886-v1.patch

Renamed metrics and function, removed unused  DEFAULT_ constant and the log on 
flush.

I'm not sure about how to get the client ip from the region, since the region 
shouldn't be aware of the client. Maybe moving something in Region Server?

heapSize() reflect the in memory state, so you've pointer size and so on... 
maybe using kv.getValueLength() + kv.getKeyLength() or just valueLength()?

I've to look at OperationMetrics, but seems that updatePutMetrics() is not 
called for doMiniBatchPut()... (I've to take a look at that)
                
> Add new metric for possible data loss due to puts without WAL 
> --------------------------------------------------------------
>
>                 Key: HBASE-5886
>                 URL: https://issues.apache.org/jira/browse/HBASE-5886
>             Project: HBase
>          Issue Type: New Feature
>          Components: metrics, regionserver
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>              Labels: metrics
>         Attachments: HBASE-5886-v0.patch, HBASE-5886-v1.patch
>
>
> Add a metrics to keep track of puts without WAL and possible data loss size.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to