BukrosSzabolcs commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-645990655
@huaxiangsun About your last question. Well, yes, the test is not obvious. If you check the code you can see that setting a Procedure on the master replica node just before we would call `assignAsync` would make `preTransitCheck` fail and throw an `HBaseIOException`. I would have preferred something more direct, but `finishActiveMasterInitialization` is a monster method and couldn't find a nice way to show what's happening. I was considering reading the logs to verify an exception was logged, but that felt like an overkill. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
