huaxiangsun commented on a change in pull request #1903:
URL: https://github.com/apache/hbase/pull/1903#discussion_r442538908
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1166,7 +1166,11 @@ private void
finishActiveMasterInitialization(MonitoredTask status) throws IOExc
assignmentManager.checkIfShouldMoveSystemRegionAsync();
status.setStatus("Assign meta replicas");
MasterMetaBootstrap metaBootstrap = createMetaBootstrap();
- metaBootstrap.assignMetaReplicas();
+ try {
+ metaBootstrap.assignMetaReplicas();
+ } catch (HBaseIOException e){
Review comment:
```
void assignMetaReplicas()
throws IOException, InterruptedException, KeeperException {
```
I think there is no InterruptedException, we can remove it from the
prototype. In your patch, only HBaseIOException is handled, how about other
IOException? Can we just catch IOException as well? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
