Apache9 commented on pull request #1903:
URL: https://github.com/apache/hbase/pull/1903#issuecomment-649627876
Next time please fix the checkstyle issues before merging? We do not count
checkstyle as -1 only because sometimes it is a bit hard to fix all the
problems and also sometimes the violations are not introduced by the patch. But
here the checkstyle issues are introduced by the PR...
And please do not comment out a line of code? Just remove it. I see this in
patch
```
public static class BrokenTransitRegionStateProcedure extends
TransitRegionStateProcedure {
protected BrokenTransitRegionStateProcedure() {
//super(env, hri, assignCandidate, forceNewPlan, type);
super(null, null, null, false,TransitionType.ASSIGN);
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
