ndimiduk commented on a change in pull request #1992:
URL: https://github.com/apache/hbase/pull/1992#discussion_r446993121
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -20,6 +20,9 @@ DRY_RUN=${DRY_RUN:-1} #default to dry run
DEBUG=${DEBUG:-0}
GPG=${GPG:-gpg}
GPG_ARGS=(--no-autostart --batch)
+if [ -n "${GPG_KEY}" ]; then
Review comment:
When is `GPG_KEY` not set? The script builds up the `@apache.org` email
address, so it should always be available. Shouldn't that be an error case?
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -20,6 +20,9 @@ DRY_RUN=${DRY_RUN:-1} #default to dry run
DEBUG=${DEBUG:-0}
GPG=${GPG:-gpg}
GPG_ARGS=(--no-autostart --batch)
+if [ -n "${GPG_KEY}" ]; then
+ GPG_ARGS=("${GPG_ARGS[@]}" --local-user "${GPG_KEY}")
Review comment:
Again, to my previous comments, I'm surprised this script identifies GPG
identity via an email address/`--local-user`. I expected that we'd manage
everything via a key fingerprint/`--default-key`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
