busbey commented on a change in pull request #1992:
URL: https://github.com/apache/hbase/pull/1992#discussion_r447390793
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -20,6 +20,9 @@ DRY_RUN=${DRY_RUN:-1} #default to dry run
DEBUG=${DEBUG:-0}
GPG=${GPG:-gpg}
GPG_ARGS=(--no-autostart --batch)
+if [ -n "${GPG_KEY}" ]; then
+ GPG_ARGS=("${GPG_ARGS[@]}" --local-user "${GPG_KEY}")
Review comment:
it doesn't identify the gpg identity necessarily via email address.
`--local-user` takes the name of a key, the same as `--default-key` does. that
name can be a keyid, email address, or fingerprint. the `--local-user` option
is defined as "I specifically want you to use this identity to sign" and
overrides any given default. IMO that better fits our usage because we
expressly want to sign with this key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
