comnetwork commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r452620948
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java ########## @@ -231,4 +231,9 @@ protected long writeWALTrailerAndMagic(WALTrailer trailer, byte[] magic) throws protected OutputStream getOutputStreamForCellEncoder() { return asyncOutputWrapper; } + + @Override + public long getSyncedLength() { + return this.output.getSyncedLength(); Review comment: Just as above mentioned, because current PR is backport, after this PR is applied to 2.x, I would open another addnum PR for both master and 2.x to incorporate your suggestions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org