madrob commented on a change in pull request #2058:
URL: https://github.com/apache/hbase/pull/2058#discussion_r453755216
##########
File path: hbase-shell/src/main/ruby/shell/commands/balancer.rb
##########
@@ -44,7 +44,9 @@ def command(force = nil)
elsif !force.nil?
raise ArgumentError, "Invalid argument #{force}."
end
- formatter.row([admin.balancer(force_balancer) ? 'true' : 'false'])
+ did_balancer_run = !!admin.balancer(force_balancer)
+ formatter.row([did_balancer_run.to_s])
+ did_balancer_run
Review comment:
Does it make sense to put this pattern in a method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
