bitoffdev commented on a change in pull request #2058:
URL: https://github.com/apache/hbase/pull/2058#discussion_r456618217
##########
File path: hbase-shell/src/main/ruby/shell/commands/clear_deadservers.rb
##########
@@ -35,18 +37,20 @@ def help
end
# rubocop:disable Metrics/AbcSize
- # rubocop:disable Metrics/MethodLength
def command(*dead_servers)
servers = admin.clear_deadservers(dead_servers)
if servers.size <= 0
formatter.row(['true'])
+ []
else
formatter.row(['Some dead server clear failed'])
formatter.row(['SERVERNAME'])
- servers.each do |server|
- formatter.row([server.toString])
+ server_names = servers.map { |server| server.toString }
Review comment:
This is just a change to collect all the server names as an array so
that we can both print and return the list of servers that could not be cleared
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
