taklwu commented on a change in pull request #2113:
URL: https://github.com/apache/hbase/pull/2113#discussion_r460475603
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java
##########
@@ -71,8 +71,8 @@ private static void writeFsLayout(Path rootDir, Configuration
conf) throws IOExc
LOG.info("BOOTSTRAP: creating hbase:meta region");
FileSystem fs = rootDir.getFileSystem(conf);
Path tableDir = CommonFSUtils.getTableDir(rootDir,
TableName.META_TABLE_NAME);
- if (fs.exists(tableDir) && !fs.delete(tableDir, true)) {
- LOG.warn("Can not delete partial created meta table, continue...");
+ if (fs.exists(tableDir)) {
Review comment:
as Zack and I highlighted in the comments above, we found the change was
from HBASE-24471 and it's a bit different from that change before (I agreed
that change is solving the meta startup/bootstrap problem.).
let me send another update and add a feature flag to be able to turn off
delete partial meta (default is to delete it). Then for the cloud case, we can
turn it off for the cloud use case that ZK data has been deleted before we come
up a better way to tell what is partial. (sorry that I don't have a good way to
validate if meta is `partial` from previous bootstrap. any suggestion?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
