anoopsjohn commented on a change in pull request #2113:
URL: https://github.com/apache/hbase/pull/2113#discussion_r461312050
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java
##########
@@ -71,7 +71,11 @@ private static void writeFsLayout(Path rootDir,
Configuration conf) throws IOExc
LOG.info("BOOTSTRAP: creating hbase:meta region");
FileSystem fs = rootDir.getFileSystem(conf);
Path tableDir = CommonFSUtils.getTableDir(rootDir,
TableName.META_TABLE_NAME);
- if (fs.exists(tableDir) && !fs.delete(tableDir, true)) {
+ boolean removeMeta = conf.getBoolean(HConstants.REMOVE_META_ON_RESTART,
Review comment:
>also, do you mean if the clusterID did't write to ZK, is it partial
during bootstrap ?
I am not sure whether that can be really used. I need to check the code. We
need a way to identify the fact that its a cluster redeploy. Not use some
config to identify that.. The HBase system should be smart enough. So I was
just wondering whether this we can use to know that. May be not.. Need to see.
So my thinking is this that we will make the feature of recreate a cluster on
top of existing data a 1st class feature for HBase itself.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java
##########
@@ -71,7 +71,11 @@ private static void writeFsLayout(Path rootDir,
Configuration conf) throws IOExc
LOG.info("BOOTSTRAP: creating hbase:meta region");
FileSystem fs = rootDir.getFileSystem(conf);
Path tableDir = CommonFSUtils.getTableDir(rootDir,
TableName.META_TABLE_NAME);
- if (fs.exists(tableDir) && !fs.delete(tableDir, true)) {
+ boolean removeMeta = conf.getBoolean(HConstants.REMOVE_META_ON_RESTART,
Review comment:
>also, do you mean if the clusterID did't write to ZK, is it partial
during bootstrap ?
I am not sure whether that can be really used. I need to check the code. We
need a way to identify the fact that its a cluster redeploy. Not use some
config to identify that.. The HBase system should be smart enough. So I was
just wondering whether this we can use to know that. May be not.. Need to see.
So my thinking is this that we will make the feature of recreate a cluster on
top of existing data a 1st class feature for HBase itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
