busbey commented on a change in pull request #2180:
URL: https://github.com/apache/hbase/pull/2180#discussion_r463649812
##########
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
##########
@@ -69,7 +69,7 @@
Compression.Algorithm.NONE, Compression.Algorithm.GZ
};
- protected Configuration conf;
+ protected final Configuration conf;
Review comment:
> should it be changed to IA Private here?
no, there 's a whole back and forth community discussion that has been
on-going in bits and pieces for years. the short version is that we definitely
need something downstream facing for running tests of hbase client code, but no
one has provided a clean way to separate that out from how we test our own
stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
