virajjasani commented on a change in pull request #2180:
URL: https://github.com/apache/hbase/pull/2180#discussion_r463946742
##########
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
##########
@@ -69,7 +69,7 @@
Compression.Algorithm.NONE, Compression.Algorithm.GZ
};
- protected Configuration conf;
+ protected final Configuration conf;
Review comment:
Since we are anyways going to release note the breaking change, can we
also make this field `private`? Downstream extended classes will have to
mandatorily start using super constructor for setting `conf` anyways and now
that it is `final`, we can also make it `private`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
