joshelser commented on a change in pull request #2193:
URL: https://github.com/apache/hbase/pull/2193#discussion_r465102036
##########
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
##########
@@ -76,4 +77,13 @@
long getWALEditsRead();
long getShippedOps();
long getEditsFiltered();
+ /**
+ * Sets the total usage of memory used by edits in memory read from WALs.
+ * @param usage The memory used by edits in bytes
+ */
+ void setWALReaderEditsBufferBytes(long usage);
Review comment:
IIRC, the type hierarchy is terrible and prevented this from being done
in a more clean way (that wouldn't require an unsafe cast), but let me
double-check that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]