joshelser commented on a change in pull request #2193:
URL: https://github.com/apache/hbase/pull/2193#discussion_r465154178
##########
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
##########
@@ -314,4 +314,15 @@ public String getMetricsName() {
@Override public long getEditsFiltered() {
return this.walEditsFilteredCounter.value();
}
+
+ @Override
+ public void setWALReaderEditsBufferBytes(long usage) {
+ //noop. Global limit, tracked globally. Do not need per-source metrics
Review comment:
> looks like ReplicationSource class has access to the MetricsSource
object.. we can just update the byte usage for that source? (and the global too
at the same time). That way we can also get rid of the special logic to update
one metric setWALReaderEditsBufferBytes()
You are correct that we could do that. I wanted to keep this change scoped
on "make what we currently have reportable". I am all for doing a per-source
tracking in addition to the globally-scoped tracking. I'd rather just keep
these two things separate :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
