anoopsjohn commented on a change in pull request #2198:
URL: https://github.com/apache/hbase/pull/2198#discussion_r465907752
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -194,30 +232,34 @@ private void decorateConf() {
}
@Override
- public void enqueueLog(Path log) {
- String logPrefix =
AbstractFSWALProvider.getWALPrefixFromWALName(log.getName());
+ public void enqueueLog(Path wal) {
+ if (!this.filterInWALs.test(wal)) {
+ LOG.trace("NOT replicating {}", wal);
+ return;
+ }
+ String logPrefix =
AbstractFSWALProvider.getWALPrefixFromWALName(wal.getName());
PriorityBlockingQueue<Path> queue = queues.get(logPrefix);
if (queue == null) {
queue = new PriorityBlockingQueue<>(queueSizePerGroup, new
LogsComparator());
queues.put(logPrefix, queue);
if (this.isSourceActive() && this.walEntryFilter != null) {
// new wal group observed after source startup, start a new worker
thread to track it
- // notice: it's possible that log enqueued when this.running is set
but worker thread
+ // notice: it's possible that wal enqueued when this.running is set
but worker thread
// still not launched, so it's necessary to check workerThreads before
start the worker
tryStartNewShipper(logPrefix, queue);
}
}
- queue.put(log);
+ queue.put(wal);
if (LOG.isTraceEnabled()) {
- LOG.trace("{} Added log file {} to queue of source {}.", logPeerId(),
logPrefix,
+ LOG.trace("{} Added wal {} to queue of source {}.", logPeerId(),
logPrefix,
this.replicationQueueInfo.getQueueId());
}
this.metrics.incrSizeOfLogQueue();
- // This will log a warning for each new log that gets created above the
warn threshold
+ // This will wal a warning for each new wal that gets created above the
warn threshold
int queueSize = queue.size();
if (queueSize > this.logQueueWarnThreshold) {
LOG.warn("{} WAL group {} queue size: {} exceeds value of "
- + "replication.source.log.queue.warn: {}", logPeerId(),
+ + "replication.source.wal.queue.warn: {}", logPeerId(),
Review comment:
Are we changing this config name also in this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
