saintstack commented on a change in pull request #2198:
URL: https://github.com/apache/hbase/pull/2198#discussion_r465995263



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/WALEntryFilter.java
##########
@@ -49,5 +47,5 @@
    * @return a (possibly modified) Entry to use. Returning null or an entry 
with no cells will cause
    *         the entry to be skipped for replication.
    */
-  public Entry filter(Entry entry);
+  Entry filter(Entry entry);

Review comment:
       This is how it works now.... no Optional. Will leave it in this patch. 
Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to