[
https://issues.apache.org/jira/browse/HBASE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266578#comment-13266578
]
Zhihong Yu commented on HBASE-5914:
-----------------------------------
Good idea.
{code}
+ if(regions.isEmpty()) return;
{code}
Please insert space between if and (.
{code}
+ servers.removeAll(failedPlans.keySet());
{code}
I think we should check whether servers is empty before proceeding.
I suggest letting quickAssign() return boolean to indicate whether 'quick'
assignment is successful.
> Using bulk assign regions in the process of ServerShutdownHandler
> -----------------------------------------------------------------
>
> Key: HBASE-5914
> URL: https://issues.apache.org/jira/browse/HBASE-5914
> Project: HBase
> Issue Type: Improvement
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: HBASE-5914.patch
>
>
> In the process of ServerShutdownHandler, we currently assign regions singly.
> In the large cluster, one regionserver always carried many regions, this
> action is quite slow.
> What about using bulk assign regions like cluster start up.
> In current logic, if we failed assigning many regions to one destination
> server, we will wait unitl timeout,
> however in the process of ServerShutdownHandler, we should retry it to
> another server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
