bsglz commented on a change in pull request #2254:
URL: https://github.com/apache/hbase/pull/2254#discussion_r470423500
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
##########
@@ -508,35 +508,57 @@ default void postAssign(final
ObserverContext<MasterCoprocessorEnvironment> ctx,
* Called prior to unassigning a given region.
* @param ctx the environment to interact with the framework and master
* @param regionInfo
- * @param force whether to force unassignment or not
*/
default void preUnassign(final ObserverContext<MasterCoprocessorEnvironment>
ctx,
- final RegionInfo regionInfo, final boolean force) throws IOException {}
+ final RegionInfo regionInfo) throws IOException {}
/**
* Called after the region unassignment has been requested.
* @param ctx the environment to interact with the framework and master
* @param regionInfo
+ */
+ default void postUnassign(final
ObserverContext<MasterCoprocessorEnvironment> ctx,
+ final RegionInfo regionInfo) throws IOException {}
+
+ /**
+ * Called prior to unassigning a given region.
+ * @param ctx the environment to interact with the framework and master
+ * @param regionInfo region info
+ * @param force whether to force unassignment or not
+ * @deprecated since 2.4.0 and will be removed in 4.0.0.
+ * Use {@link #preUnassign(ObserverContext, RegionInfo)} instead.
+ */
+ @Deprecated
+ default void preUnassign(final ObserverContext<MasterCoprocessorEnvironment>
ctx,
+ final RegionInfo regionInfo, final boolean force) throws IOException {}
+
+ /**
+ * Called after the region unassignment has been requested.
+ * @param ctx the environment to interact with the framework and master
+ * @param regionInfo region info
* @param force whether to force unassignment or not
+ * @deprecated since 2.4.0 and will be removed in 4.0.0.
Review comment:
Make sense, let's remove it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
