bsglz commented on a change in pull request #2254:
URL: https://github.com/apache/hbase/pull/2254#discussion_r470428399
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -537,8 +537,8 @@ def assign(region_name)
#----------------------------------------------------------------------------------------------
# Unassign a region
- def unassign(region_name, force)
- @admin.unassign(region_name.to_java_bytes,
java.lang.Boolean.valueOf(force))
+ def unassign(region_name)
Review comment:
Will fix later. Thanks.
##########
File path: hbase-shell/src/main/ruby/shell/commands/unassign.rb
##########
@@ -23,23 +23,18 @@ class Unassign < Command
def help
<<-EOF
Unassign a region. It could be executed only when region in expected
state(OPEN).
-Pass 'true' to force the unassignment ('force' will clear all in-memory state
in
-master before the reassign. If results in double assignment use hbck -fix to
resolve.
-To be used by experts).
In addition, you can use "unassigns" command available on HBCK2 tool to skip
the state check.
(For more info on HBCK2:
https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md)
Use with caution. For experts only.
Examples:
hbase> unassign 'REGIONNAME'
- hbase> unassign 'REGIONNAME', true
hbase> unassign 'ENCODED_REGIONNAME'
- hbase> unassign 'ENCODED_REGIONNAME', true
EOF
end
- def command(region_name, force = 'false')
- admin.unassign(region_name, force)
+ def command(region_name)
Review comment:
Will fix later. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
