apurtell commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r471676264
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdminOverAsyncAdmin.java
##########
@@ -1057,4 +1057,9 @@ public void updateRSGroupConfig(String groupName,
Map<String, String> configurat
throws IOException {
get(admin.updateRSGroupConfig(groupName, configuration));
}
+
+ @Override
+ public List<BalancerDecisionRecords> getBalancerDecisions() throws
IOException {
Review comment:
If we have this type of API, it should be possible to provide a limit,
e.g.
public List getLogEntries(String name, int limit);
so that a client that is memory constrained (or wants to be frugal) doesn't
have to worry about invoking this and maybe getting back a list of 5000 entries
or whatever, by passing in a limit of 100, or 10, or ...
It would be fine to also provide a method that doesn't accept a limit, for
convenience. Prerequisite: The methods are generic enough so we don't add a
pair (or more!) for every type. E.g.
public List getLogEntries(String name) { this(name, Integer.MAX_VALUE); }
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
